Fixing Xerces dtd/schema backward compatibility #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Changes
quickfix.Message#toXML(quickfix.DataDictionary)
- it is not required as we are neither loading, nor validation against schemasComments
org.quickfixj.codegenerator.MessageCodeGenerator
as it uses files that belong to the codebase, so changes pointing to external dtd/schema would be visible in PRs (the only reason I can think to keep it there is if somebody is dependent onorg.quickfixj:quickfixj-codegenerator
directly in their project to customise message generation)javax.xml.parsers.DocumentBuilderFactory
with custom properties or features (https://xerces.apache.org/xerces2-j/features.html, https://xerces.apache.org/xerces2-j/properties.html). Additional changes have to be made to propagatejavax.xml.parsers.DocumentBuilderFactory
across the board.