New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject duplicate active sessions #21

Closed

cbusbey opened this issue Mar 24, 2013 · 0 comments

Milestone

Contributor

cbusbey commented Mar 24, 2013

AlreadyLoggedOn.def

cbusbey closed this as completed

ackleymi pushed a commit that referenced this issue


          Bug: For Logon/Logout/Resend/SequenceReset messages we should wait un…

6eaa8ce

…til sent (#21)

## Issue 
When log on request was queued because cannot be send due to connection
not ready,
Then it goes through the [main session
loop](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session.go#L821-L841)
which leads to
[SendAppMessages](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session_state.go#L107-L111)

But, since session is not logged on yet because the message queued is
the log on message, we drop the `toSend` queued messages so we lose the
log on message itself.


## Proposed solution
For important messages like Logon/Logout/Resend/SequenceReset we block
until sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment