Escape send queued when blocked on connection side #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use default instead of a timer refactor send queued In case of Log On messages block until sent
AlexandrosKyriakakis
force-pushed
the
escape-send-queued-when-blocked
branch
from
6ab6782
to
d7f2968
Compare
|
@ackleymi any thoughts about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Observations
session.sendMutexSo, if there are many messages in the slice
toSend, session from our side is blocked until all the messages are sent.At the same time, if halfway (when half of the messages in
toSendhave been sent) the other side cannot accept more messages (maybe cause of a buffer overflow) in order to be unblocked, we need to consume some of the incoming messages, which with the current implementation cannot happen.Proposed solution
When sending queued messages, if any of the messages cannot be sent, then we escape the
toSendloop and leave the rest of the messages for the next session loop.