Implement Array.prototype.toReversed #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Nov 6, 2023
| if (JS_IsException(arr)) | ||
| goto exception; | ||
|
|
||
| if (len > 0) { |
There was a problem hiding this comment.
Would it make sense to return early here?
There was a problem hiding this comment.
I think I copied this pattern from elsewhere in this file and I kind of agree with it because it means fewer calls to JS_FreeValue(). I try hard to keep the reference counting in one place, otherwise it's too easy to screw up.
If you don't like the indent level, I could change it to a goto.
There was a problem hiding this comment.
Good point about the consistency. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.