Implement Error.prepareStackTrace support #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bnoordhuis Can you PTAL? It's not fully finished yet (see TODOs) but I'd like some feedback on the approach. The tricky part was to avoid doing anything while iterating through the stack frames since they could get modified while we are iterating over them. Edit: also, do you reckon there is more low hanging fruit I could add, to make the API closer to V8's? |
TooTallNate
reviewed
Dec 18, 2023
bnoordhuis
reviewed
Dec 18, 2023
saghul
commented
Dec 18, 2023
saghul
force-pushed
the
error-prepareStackTrace
branch
from
da9c7b2
to
66c95b4
Compare
|
Alright, this is one is ready now, PTAL @bnoordhuis ! |
bnoordhuis
approved these changes
Dec 19, 2023
Based on V8's API: https://v8.dev/docs/stack-trace-api. Bits picked from Frida: frida/quickjs@78fd25f Closes: #134
saghul
force-pushed
the
error-prepareStackTrace
branch
from
66c95b4
to
07fad07
Compare
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on V8's API: https://v8.dev/docs/stack-trace-api.
Bits picked from Frida: frida/quickjs@78fd25f
Closes: #134