fix compile bug under clang(backend MSVC) #253
Conversation
| endfunction() | ||
|
|
||
| set(is_msvc 0) | ||
| IsMSVC(is_msvc) |
There was a problem hiding this comment.
Just inline the var declaration instead of calling that parent scope-manipulating function? You're only using it once; less indirection is better, ceteris paribus.
| # ClangCL is command line compatible with MSVC, so 'MSVC' is set. | ||
| if(MSVC) | ||
| if(${is_msvc}) |
There was a problem hiding this comment.
The comment should probably be updated. Also, why write ${is_msvc} here but plain is_msvc elsewhere?
| @@ -54,7 +65,7 @@ if(MSVC) | |||
| xcheck_add_c_compiler_flag(-Wno-reserved-macro-identifier) | |||
| xcheck_add_c_compiler_flag(-Wno-reserved-identifier) | |||
| xcheck_add_c_compiler_flag(-Wdeprecated-declarations) | |||
| add_compile_definitions(WIN32_LEAN_AND_MEAN) | |||
| add_compile_definitions(WIN32_LEAN_AND_MEAN _CRT_SECURE_NO_WARNINGS _CRT_NONSTDC_NO_DEPRECATE) | |||
There was a problem hiding this comment.
I think we want to keep those warnings so can you undo this change?
| @@ -612,6 +612,7 @@ void rqsort(void *base, size_t nmemb, size_t size, cmp_f cmp, void *opaque) | |||
| } | |||
|
|
|||
| #if defined(_MSC_VER) | |||
| struct timezone; | |||
There was a problem hiding this comment.
The include <time.h> should pull this in, right? Why doesn't that work with clang?
| @@ -211,8 +211,6 @@ typedef enum { | |||
| JS_GC_PHASE_REMOVE_CYCLES, | |||
| } JSGCPhaseEnum; | |||
|
|
|||
| typedef enum OPCodeEnum OPCodeEnum; | |||
There was a problem hiding this comment.
This also looks like a change that shouldn't be necessary. What exactly was the warning or error you got?
|
Ping? The CI also tests Clang 17, without failure. How exactly are you compiling it? |
|
No follow-up, closing. Please holler if you want to pick this back up. |
Compile failed under:
Because clang's backend is MSVC, so all
add_definitionsapply on MSVC also should apply on clang.Use
to replace all
MSVCdetect.