Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutils - Compatibility for compiling under c++ #457

Closed
wants to merge 1 commit into from

Conversation

andrjohns
Copy link
Contributor

Minor changes needed for compiling cutils.c under C++:

  • Explicitly cast when assigning from void* to other types
  • digits36 array length forgets null-terminator

@saghul
Copy link
Contributor

saghul commented Jul 2, 2024

Is there a way to add a CI target for this? Otherwise I fear we'll break it over and over again...

@andrjohns
Copy link
Contributor Author

Is there a way to add a CI target for this? Otherwise I fear we'll break it over and over again...

Yep, but there are still a bunch of changes needed for the other headers/files so I was going to hold off until the full project was compile-able

@saghul
Copy link
Contributor

saghul commented Jul 2, 2024

Do you reckon it would be good to land all changes in a single PR?

@andrjohns
Copy link
Contributor Author

Do you reckon it would be good to land all changes in a single PR?

Yeah probably makes sense to see it all at once, and then can always split after. Will do!

@andrjohns andrjohns closed this Jul 2, 2024
@andrjohns andrjohns deleted the cpp-compat-cutils branch July 4, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants