Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hu.dwim.util has no :AUTHOR #1671

Closed
phoe opened this issue Apr 23, 2019 · 6 comments
Closed

hu.dwim.util has no :AUTHOR #1671

phoe opened this issue Apr 23, 2019 · 6 comments

Comments

@phoe
Copy link

phoe commented Apr 23, 2019

According to the Quicklisp's guidelines:

The system definition(s) for the project should include :DESCRIPTION, :AUTHOR, and :LICENSE options.

The systems of hu.dwim.util do not have the :AUTHOR field in their ASD file:

http://dwim.hu/live/hu.dwim.util/hu.dwim.util.asd

@mfiano
Copy link
Contributor

mfiano commented Apr 23, 2019

The bigger issue as to why it shouldn't be included in Quicklisp, is it taints an SBCL image because it does:

(sb-ext::without-package-locks
  (defun sb-impl::line-length (&optional (stream *standard-output*))
    (declare (ignore stream))
    160))

@phoe
Copy link
Author

phoe commented Apr 23, 2019

The bigger issue as to why it shouldn't be included in Quicklisp

Anyone can have their code included in Quicklisp, since the repository is not curated.

Also, for correctness, the above code is from hu.dwim.asdf, not hu.dwim.util. http://dwim.hu/live/hu.dwim.asdf/source/system.lisp

@phoe
Copy link
Author

phoe commented Apr 23, 2019

Somewhat-related SBCL ticket: https://bugs.launchpad.net/sbcl/+bug/501075

@attila-lendvai
Copy link
Contributor

sorry for the mess! it's removed now and should be gone in the next ql update.

@attila-lendvai
Copy link
Contributor

as of the original issue: once hu.dwim.util is loaded, it should get a default value into its author and licence slots inherited from its superclass hu.dwim.system.

@phoe
Copy link
Author

phoe commented Apr 23, 2019

Oh - is that what the :class "hu.dwim.asdf:hu.dwim.system" line does? I need to read up on that part of ASDF one day. Thanks!

@phoe phoe closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants