Permit mapped accounts with 118 zones

[joe-bowman]

1. Summary

Fixes #1531

2.Type of change

• Bug fix (non-breaking change which fixes an issue)

Remove the conditional that checks the zone.Is_118 field prior to utilising a MappedAccount.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 5:27pm

[coderabbitai]

Walkthrough

The update primarily involves the MintAndSendQAsset function within the Keeper struct, where a specific condition related to zone.Is_118 has been removed. This adjustment simplifies the condition logic, allowing for broader use of mapped accounts in different zone types.

Changes

File Path	Change Summary
x/interchainstaking/keeper/...	Removed zone.Is_118 condition from MintAndSendQAsset.

Assessment against linked issues

Objective	Addressed	Explanation
Allow mapped accounts for 118 cointype zones (#1531)	✅
Add field to RegisterZoneProposal for specifying ICA/MSICA mechanism (#34)	❌	The changes are unrelated to RegisterZoneProposal modifications or ICA/MSICA specifications.

Possibly related issues

• quicksilver-zone/quicksilver-private#34: Although this issue discusses account types and initialization, the current changes focus on enabling mapped accounts for 118 zones, which might indirectly support multi-account setups.

Poem

🐰🎉
In the land of code, where the bits roam free,
A small change was made, oh what a spree!
No longer bound by zone.Is_118,
Mapped accounts can now set, a smoother bet.
Here's to simpler code, with less fuss,
Hop, hop, hurray! From us, the CodeRabbit, with no muss! 🥕🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.41%. Comparing base (6d452b1) to head (7e47ca3).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1532   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files         194      194           
  Lines       13632    13632           
=======================================
  Hits         8508     8508           
  Misses       4308     4308           
  Partials      816      816           

Flag	Coverage Δ
unittests	62.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
x/interchainstaking/keeper/receipt.go	77.91% <0.00%> (ø)