Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seeds for easy mainnet connect and webui #936

Merged
merged 9 commits into from
Dec 31, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 24, 2023

1. Summary

Please merge the test matrix first. This PR adds seeds to quicksilver so that it can easily autoconnect to mainnet.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

Add seeds to the binary, like bitcoin and osmosis.

4. How to test/use

When you quicksilverd init you should get seeds auto populated.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2783379) 61.75% compared to head (0859212) 61.88%.
Report is 2 commits behind head on main.

❗ Current head 0859212 differs from pull request most recent head 6034b8b. Consider uploading reports for the commit 6034b8b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   61.75%   61.88%   +0.12%     
==========================================
  Files         172      172              
  Lines       14116    14083      -33     
==========================================
- Hits         8718     8715       -3     
+ Misses       4651     4623      -28     
+ Partials      747      745       -2     
Flag Coverage Δ
unittests 61.88% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/quicksilverd/root.go 59.45% <100.00%> (+0.90%) ⬆️

... and 12 files with indirect coverage changes

@faddat faddat enabled auto-merge (squash) December 24, 2023 17:14
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@faddat faddat merged commit 8953bb0 into main Dec 31, 2023
14 checks passed
@joe-bowman joe-bowman deleted the add-seeds-for-easy-mainnet-connect-and-webui branch December 31, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants