-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce bundle version requirements #1261
Enforce bundle version requirements #1261
Conversation
This array might never get used. At most, it will be used once.
Enforce bundle version requirements
Yeah, so the next release, which is pretty far off. Should we go ahead with it now, knowing it will kill iTunes DJ actions for users of iTunes 10? Edit |
I haven't looked at the iTunes pull yet, so it might be a bit off (although, you seem to be semi-autonomous on the iTunes plugin anyway, so I'd be happy for you to merge if it now if you really want) The change is small, so we could merge this into release as well then get the iTunes plugin out for ß71. |
Not sure when this diverged from master. We might have to cherry-pick it into release, which could make a big mess. Maybe I'll just release the iTunes plug-in now, and if anyone still using 10 complains, I can give a link to the old version. I mainly want to get it out because there are some crashes with iTunes 11. |
Alright, go for it from my point of view. At the very least, it may be worth marking the new plugin's maxOSVersion on On 21 December 2012 13:23, Rob McBroom notifications@github.com wrote:
|
I was planning to require iTunes 11 for the next version of the plug-in, but it wasn't working. I found there was nothing but a warning where version checking should be. :-)
While in that method, I also localized all the errors.
I've also included one unrelated commit that fixes a warning I ran across.