-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent user-disabled objects from appearing #1688
Conversation
We can’t globally make the change in scannedObjects or contentsScanIfNeeded:, because there are places where the objects should still appear. For one, they should appear in the prefs so you can re-enable them.
This bug was kind of addressed a while back. I added an It might be worth looking at that to see if it can be changed/tweaked or if the logic from what you've done can be combined in some way. |
OK. Does that just take care of the first pane, or does it get other places, too?
Rings a bell. I think I took the position that the browsing the filesystem should always tell the truth, ignoring catalog stuff. So I think we agree, and that’s how this works. The changes should only affect the catalog, but browsing/right-arrowing should still be the same as before. The exception to that is right-arrowing into a catalog entry itself, since I’ve gone out of the way to prevent that from showing disabled objects. But that makes sense if you ask me. It matches what you see checked under “Contents” in the prefs that way. |
Yep, that’s what I think. Right arrowing into catalog entries sounds right as well :) On 24 Nov 2013, at 04:56, Rob McBroom notifications@github.com wrote:
|
I think the reason it wasn’t working before based on the
Something else worth noting about this branch: If an object source gets children by calling Again, I think that behavior makes sense. If you explicitly disable a contact, it shouldn’t appear when right-arrowing into Contacts.app. I think it should be up to the plug-in to decide the best behavior. But it might be worth documenting this (if this gets merged) so developers will know what to expect. I can also explain how to use some manual process to get children, while still omitting disabled objects, in case anyone has a need to do that. |
OK, please make "documenting this" a post-prerequisite ;-) |
Prevent user-disabled objects from appearing
OK. I think Etienne was going to fix this some other way, but that can always be done later. I’ll update the documentation. |
Oops, sorry if Ive messed things up in my excitement/mad rush now I finally have decent internet. I’m on IRC if need be. 20 minutes or so then it’ll be bed On 2 Dec 2013, at 22:42, Rob McBroom notifications@github.com wrote:
|
Unchecking individual QSObjects in the catalog would prevent them from appearing when you searched in the first pane, but they would still appear in the third pane and when right arrowing. I’ve fixed that.
Ideally, we could take care of this as part of #1601, but I gather @tiennou is too busy right now to take on additional features. I’ve at least tried to do something that won’t conflict.