Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions that return objects should clear the first pane #203

Closed
skurfer opened this issue Apr 18, 2011 · 3 comments · Fixed by #209
Closed

Actions that return objects should clear the first pane #203

skurfer opened this issue Apr 18, 2011 · 3 comments · Fixed by #209
Assignees
Labels
Milestone

Comments

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 18, 2011

I ran into this wile working on issue 182.

To reproduce:

  1. Select multiple items using the comma trick
  2. Run an action on them that returns a result to Quicksilver

The result will be displayed correctly, but the additional items selected by the comma trick will still be present underneath it. This seems to confuse Quicksilver and causes it to display the wrong actions.

I’m sure there are ways to reproduce this with existing actions, I just can’t think of any so I’ll use the new fixed Get Path action as an example. It returns a string, so the default action should be Large Type (in my case), but if you use comma to get multiple files, some of the files still appear below the string after running “Get Path” and the default action becomes “Open”. If you try to choose Paste with Clipboard, you get EXC_BAD_ACCESS.

When Quicksilver runs an action that has displaysResult in its property list entry, it should wipe the entire first pane, not just the most recent object.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Apr 18, 2011

Also note that these actions work fine with multiple objects without the comma trick. If you use ⌘A for instance, or select multiple files in Finder and use ⌘G.

FYI, the new improved Get Path action can be found in my branch for issue 182.

@ghost ghost assigned skurfer Apr 19, 2011
@skurfer
Copy link
Member Author

@skurfer skurfer commented Apr 19, 2011

I think I’ve fixed this, but I’m not sure of the ramifications. I’m going to run with the fix full time to see if it broke anything else.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Apr 19, 2011

Fixed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants