Also clear text when clearing object view

[pjrobertson]

Fixes #2289

[skurfer]

I’m still able to reproduce the original issue with this change.

It seems to me like the text mode string should be cleared as soon as you initiate a search and something else gets selected. Or maybe the current behavior is fine and we shouldn’t worry about it? 🤷🏻‍♂️

[pjrobertson]

Hmm... am I following the right steps? See below:

s.mov

[skurfer]

So, I noticed something strange in your video. As you hit Delete, the selection changes. I had never seen that happen, then I remembered you’re a monster and use that one-character-at-a-time delete preference. 😜

If I disable double-Delete to clear the selection, I see what you see.

Maybe we should clear the text string inside clearSearch instead?

[pjrobertson]

You caught me!

Maybe we should clear the text string inside clearSearch instead?

Should be a simple enough fix, yes. I'll look into it and update this PR.

[skurfer]

That might be too heavy handed. It’s called from 11 places. Maybe we should create a clearSearchAndText that calls clearSearch and adds your new code? Or just repeat the code in that method.

[pjrobertson]

OK, so you were right that clearing the text string in clearSearch was too heavy handed. I just tried that and it broke everything. That's because clearSearch is called every time you type anything into the search field (it's more akin to 'reset and get ready to redo another search').

I cleared the string in the 3 places I can think it makes sense:

1. Deleting backwards with 'Pressing the Delete key clears the whole search string' off (my case)
2. Deleting backwards with 'Pressing the Delete key clears the whole search string' on (Rob's case)
3. Pressing ⌃U to clear the search object

I think that's good enough for now :)