Fall back to the English defaultsMap file if no localisation file can be found. Fixes #1233 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1233 |
|
Is it based on In any case, I'll look it over. |
|
It's a branch from master, but the 'base branch' is release :) Just to clarify:
On 21 November 2012 13:20, Rob McBroom notifications@github.com wrote:
|
skurfer
added a commit
that referenced
this pull request
Nov 21, 2012
Fall back to the English defaultsMap file if no localisation file can be found. Fixes #1233
|
Go ahead and merge to master. |
skurfer
added a commit
that referenced
this pull request
Nov 21, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I localised this file recently., but of course didn't think of the situation where a user might not even have English as an option in their language system prefs. This ensures the English file is used if no localisation can be found.
Based against the release branch. Should be merged into master once done.