Add trigger the return #1345
Add trigger the return #1345
Conversation
…eferences. Also makes the QSTriggerManager informal protocol a formal one, and move it in QSTriggerManager.h. The changes to the xib file are bindings for the infoButton & deleteButton.
Only one? Rock solid testing ;-) Cheers for getting this out. So... does that mean that there are no more outstanding v1.0 issues to fix? I'm scared! |
|
I just rebased the old |
|
Yep. Looks good. No crashing this time. I reverse my opinion on renaming it to "Add Hotkey Trigger". I say we leave it, because once the trigger is created, you can change the type. (You have to edit it anyway, so I think that's fine.) How hard would it be to select the new trigger when the preferences open? :-) |
Or you get a WebKitThreadingViolation in the face ;-).
|
Rebased. Now supports passing the trigger type as an indirect. I'll fix the trigger selection in the pref pane and await your opinions ;-). |
|
Also, I removed the xib file change from that list, but that didn't make it work :-(. |
|
Please see a couple of my commits here that fix a few small things. I haven't fixed the pixelated-ness of the iObjects ;-) |
Fixes #515, see #563 for reference (except this one is more commit-y than the old).
I tried creating one trigger with the action ('pizza' > Large type, got that one from an old tutorial ;-)), then deleting it. No crash.