Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger the return #1345

Merged
merged 10 commits into from Feb 1, 2013
Merged

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Jan 22, 2013

Fixes #515, see #563 for reference (except this one is more commit-y than the old).

I tried creating one trigger with the action ('pizza' > Large type, got that one from an old tutorial ;-)), then deleting it. No crash.

tiennou added 2 commits Jan 22, 2013
…eferences.

Also makes the QSTriggerManager informal protocol a formal one, and move it in QSTriggerManager.h.
The changes to the xib file are bindings for the infoButton & deleteButton.
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 22, 2013

I tried creating one trigger

Only one? Rock solid testing ;-)

Cheers for getting this out. So... does that mean that there are no more outstanding v1.0 issues to fix? I'm scared!

@tiennou
Copy link
Member Author

@tiennou tiennou commented Jan 23, 2013

I just rebased the old add-trigger branch I had ;-).

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 23, 2013

Yep. Looks good. No crashing this time. I reverse my opinion on renaming it to "Add Hotkey Trigger". I say we leave it, because once the trigger is created, you can change the type. (You have to edit it anyway, so I think that's fine.)

How hard would it be to select the new trigger when the preferences open? :-)

@tiennou
Copy link
Member Author

@tiennou tiennou commented Jan 23, 2013

Rebased. Now supports passing the trigger type as an indirect. I'll fix the trigger selection in the pref pane and await your opinions ;-).

@tiennou
Copy link
Member Author

@tiennou tiennou commented Jan 23, 2013

Also, I removed the xib file change from that list, but that didn't make it work :-(.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 24, 2013

Please see a couple of my commits here that fix a few small things. I haven't fixed the pixelated-ness of the iObjects ;-)

@skurfer skurfer merged commit 0aaec29 into quicksilver:master Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants