New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(10.7+) New Plugin updater. Fixes #1332 #1354
Conversation
Plus - pass the whole QSPlugin to the updater (in an NSDict) to simplify the setup process of the window
Really cool. The Safari icon was too small for me, but that's probably a retina thing. I'll look it over in more detail tomorrow. Yes to the title bar. As long as you're improving things for plugins, I don't suppose you want to look at #999? :-) |
Yeah probably. Does the plugins icon display properly? I just use an NSImageView and Set a breakpoint on
I thought you might ask that ;-) |
OK, I've done what is desired, except actually hooking up the help button to open the help panel.
I'm inclined to go for number 2. Thoughts? |
Oh, and P.S. the help icon I made was a 2s attempt until we can get something better. I didn't see the point of me spending ages to make something rubbish :) |
Oh, and I just saw your small icon bug. It's because the image view wasn't set to scale the image correctly. |
Oh dear, view based tables are 10.7+ only. I guess this'll have to wait until after we drop 10.6 support. So next next release :) |
Yeah, I had started to work on it and came to the same conclusion. 2 sounds much cleaner.
By next release, do you mean the one we're currently working on? Because I'm on board. :-) I wonder if we should do a B72 from the current |
I have a small concern about the format of the updates. The way it list current and new versions followed by a list of changes implies that those are the changes between the two versions displayed. But really, those are only the changes between the two most recent. I would do it more like this:
Thanks for looking at #999. It looks like the help button moves around a lot. Can we put it on the parent view instead and just hide it for panes marked as "main"? And then you might not need to mess with |
Mentioned on IRC, but for the record: 10% of users are still 10.6 so it'd be nice to make v1.0 10.6+. I'll fork the #999 fixes to another pull request. I'm gonna rewrite history here. For this pull: I'll update the changes you suggest, except use the format:
|
Conflicts: Quicksilver/Quicksilver.xcodeproj/project.pbxproj
OK I've tweaked the display of the version numbers as I specified in my comment and also fixed the merge conflict. Since 10.6 is dropped this is good to go |
I'm not quite sure what the problem was (perhaps a retina thing, in which case I don't care :P ) but I've tweaked the sizes a little and made a few adjustments. Let me know how things look for you now |
I've pushed one more update. I realised that one of the main reasons for doing this was so that users can skip plugin updates (e.g. the 'broken Terminal plugin') If no plugins are ticked you can click the 'skip updates' button. Also, I've fixed a crash (hopefully the |
Not a retina thing. Like I said, it's evident in your screenshot too. Take a look. 😃 I'll try out the new changes. Didn't you already fix the |
The skip option works, but I still see the noise under Changes. |
Alright, in that case you'll need to debug yourself. On IRC right now if On 21 March 2013 20:59, Rob McBroom notifications@github.com wrote:
|
What have I done? Nooooo! Considering that it goes away when you open/close the details, it's probably an unavoidable bug, but I'll take a look. |
Discussed on IRC: I've tried playing with it, but it seems that with view based tables there's no way to set padding or anything. The only alternative is to put it in the top left hand corner |
Looks better. I don't see the noise. I wanted to see how it handled obsoletes. You can't read all the text on the first line. Not sure what the best solution is for that, but users should be able to see it. And under changes, do we really want to show |
OK, thanks for the testing :) On 25 March 2013 21:06, Rob McBroom notifications@github.com wrote:
|
OK then, finally updated this! Two more things fixed, hopefully they work for you :) |
Better visually, but it's not actually installing the new plug-in (to replace an obsolete). I get a notification that it was installed, but the old version remains the only copy. Very possible this was a pre-existing bug. I'll try to track it down and let you know. |
(10.7+) New Plugin updater. Fixes #1332
The deployment target for the new NIB here is 10.6, which throws some warnings. Feel free to change it and push straight to master. |
Cheers for the heads up. Done |
Great. Time for a release branch! |
This is seriously cool. and fixes #1332 ;-)
It adds a new modal window for installing plugins with the following features:
It could probably do with a bit of tidying up round the edges, so I thought I'd open a pull for discussion.
To test this out, you need to have some 'old' plugins on your system that you can update. Here's a script to install old versions of Safari, Terminal and Contacts (assuming you have the latest). Run it then restart QS and click 'check now' for updates:
Meh, it wasn't looking that sexy so I've added a bit of eye candy :)