Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional icon loading stuff #1438

merged 3 commits into from Apr 14, 2013

Additional icon loading stuff #1438

merged 3 commits into from Apr 14, 2013


Copy link

@skurfer skurfer commented Mar 25, 2013

These were supposed to be included with #1369, but I hadn't pushed them before it was merged. The commits are pretty well commented.

skurfer added 3 commits Mar 25, 2013
technically true, but this entire method is on a separate thread now
Too error prone, and as long as the setter is being explicitly defined,
we might as well use it for something.
Since loadIcon often does work on another thread and doesn't set a new
icon immediately, there's no point to testing the image, or calling
loadIcon first for that matter. Just blindly take the resolved object's
icon. It will get replaced if needed when loadIcon finishes.
pjrobertson added a commit that referenced this issue Apr 14, 2013
Additional icon loading stuff
@pjrobertson pjrobertson merged commit 3eb699c into quicksilver:master Apr 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants