Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return file URLs as a simple string #1845

Merged
merged 1 commit into from May 19, 2014
Merged

return file URLs as a simple string #1845

merged 1 commit into from May 19, 2014

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented May 19, 2014

Don’t call sniffString via objectWithString: because it’s a little too smart for this case.

Don’t call `sniffString` via `objectWithString:` because it’s a little
too smart.

fixes #1844
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 19, 2014

Yeah, that was my 2nd suggestion. Looks good.

I guess the objectWithString method doesn’t necessarily say a string object is going to be returned (it's not called `-[QSObject stringObjectWithString:] so it's not technically incorrect. I think you're probably right.

Can you remember which actions were fixed by the commit that broke this (was it large type or something?), just incase it'll break more things

pjrobertson added a commit that referenced this issue May 19, 2014
return file URLs as a simple string
@pjrobertson pjrobertson merged commit b049daa into master May 19, 2014
1 check passed
@pjrobertson pjrobertson deleted the fileurls branch May 19, 2014
@skurfer
Copy link
Member Author

@skurfer skurfer commented May 19, 2014

Can you remember which actions were fixed by the commit that broke this (was it large type or something?), just incase it'll break more things

See #1804. Large Type for sure, but probably anything else that looks for both the text type, and specific file types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants