Plugin icons

[pjrobertson]

It's probably something you've all seen, but haven't really thought much about...

In the plugin prefs, lots of the plugins had the horrible 'document' icons as opposed to the puzzle 'plugin' icons. Quite ugly now I'm looking at a nice list :)

I got carried away with this fix, and the reason I first looked at it was to allow looking in a plugin's resource folder for icons. You can now add an icon to a plugin's resource folder, then in the .plist just give the name of this icon and it'll load correctly.
Previously only system-wide icons or icons in QS's own resource folder would be accessible.

There's a couple of small optimisations as well :)

[skurfer]

Previously only system-wide icons or icons in QS's own resource folder would be accessible.

It could be done, but it took extra work. For instance, I had to do this everywhere in the AirPort module:

[QSResourceManager imageNamed:@"AirPort" inBundle:[NSBundle bundleForClass:[self class]]]

This’ll be a nice change.

[pjrobertson]

Sorry, I probably should have been clearer. This is only a change for
loading the small plugin icons you seen in the plugin prefs next to each
plugin name. It doesn't affect anywhere else icons are loaded. You'll still
need to do what you've been doing.

What this does change is that it means you no longer need to put a stupid
path in the Info.plist under the 'icon' key. In some previous plugins I've
had to put ~/Library/App Support/QS/Plugins/Plugin....etc. which was just
silly!

On 8 July 2011 20:33, skurfer <
reply@reply.github.com>wrote:

Previously only system-wide icons or icons in QS's own resource folder
would be accessible.

It could be done, but it took extra work. For instance, I had to do this
everywhere in the AirPort module:

[QSResourceManager imageNamed:@"AirPort" inBundle:[NSBundle
bundleForClass:[self class]]]

Thisll be a nice change.

Reply to this email directly or view it on GitHub:
#410 (comment)