Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin icons #410

Merged
merged 3 commits into from Aug 9, 2011
Merged

Plugin icons #410

merged 3 commits into from Aug 9, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 4, 2011

It's probably something you've all seen, but haven't really thought much about...

In the plugin prefs, lots of the plugins had the horrible 'document' icons as opposed to the puzzle 'plugin' icons. Quite ugly now I'm looking at a nice list :)

I got carried away with this fix, and the reason I first looked at it was to allow looking in a plugin's resource folder for icons. You can now add an icon to a plugin's resource folder, then in the .plist just give the name of this icon and it'll load correctly.
Previously only system-wide icons or icons in QS's own resource folder would be accessible.

There's a couple of small optimisations as well :)

pjrobertson added 3 commits Jul 4, 2011
…set in the .plist, don't bother looking for one
… it here).

Only set the icon if an icon exists for the file type
@skurfer
Copy link
Member

@skurfer skurfer commented Jul 8, 2011

Previously only system-wide icons or icons in QS's own resource folder would be accessible.

It could be done, but it took extra work. For instance, I had to do this everywhere in the AirPort module:

[QSResourceManager imageNamed:@"AirPort" inBundle:[NSBundle bundleForClass:[self class]]]

This’ll be a nice change.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jul 10, 2011

Sorry, I probably should have been clearer. This is only a change for
loading the small plugin icons you seen in the plugin prefs next to each
plugin name. It doesn't affect anywhere else icons are loaded. You'll still
need to do what you've been doing.

What this does change is that it means you no longer need to put a stupid
path in the Info.plist under the 'icon' key. In some previous plugins I've
had to put ~/Library/App Support/QS/Plugins/Plugin....etc. which was just
silly!

On 8 July 2011 20:33, skurfer <
reply@reply.github.com>wrote:

Previously only system-wide icons or icons in QS's own resource folder
would be accessible.

It could be done, but it took extra work. For instance, I had to do this
everywhere in the AirPort module:

[QSResourceManager imageNamed:@"AirPort" inBundle:[NSBundle
bundleForClass:[self class]]]

Thisll be a nice change.

Reply to this email directly or view it on GitHub:
#410 (comment)

skurfer added a commit that referenced this issue Aug 9, 2011
@skurfer skurfer merged commit cb98e16 into quicksilver:master Aug 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants