Small bug fixes #494
Small bug fixes #494
Conversation
… saved in the catalog bug' Basically, sniffing the object's string to create the object should be the last thing tried, or it messes up other methods of creating the object Also made a few tidy ups. It was pretty messy before :(
Plus: Updated to a 10.6 method for ejecting. Previously, the unmountAndEjectDeviceAtPath method was failing almost every time and the Finder script was used instead. This 10.6 method ejects all the mounted volumes from a single device.
|
Fixes #222 |
| if (!object) { | ||
| // sniffs the string to create a new object | ||
| object = [QSObject objectWithString:directID]; | ||
| object = [QSAction actionWithIdentifier:directID]; |
There was a problem hiding this comment.
Should the direct object be set to a QSAction here? Seems odd, but maybe there’s a reason.
There was a problem hiding this comment.
This was in Alcor's original code, but I took it out when I made the first
changes in this area. (Actually it may have been Etienne that put it in,
can't remember, don't have the internet capabilities atm to check - sorry!)
I took it out as we had no idea what it did.
This time around I left it in because I thought I shouldn't necessarily
change things just because I don't understand them.
On 5 October 2011 14:01, Rob McBroom <
reply@reply.github.com>wrote:
if (!object) {
// sniffs the string to create a new objectobject = [QSObject objectWithString:directID];object = [QSAction actionWithIdentifier:directID];Should the direct object be set to a QSAction here? Seems odd, but maybe
theres a reason.Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/494/files#r155754
There was a problem hiding this comment.
I keep a copy of the B54 code (or at least it’s the oldest commit we have) for reference. There’s no mention of QSAction in that method. My guess is something got copied and pasted, but not changed to suit the new context. I say yank it.
There was a problem hiding this comment.
OK then I'm pretty sure Etienne put it in when he made the changes there
before me. I'll yank it :)
On 6 October 2011 19:34, Rob McBroom <
reply@reply.github.com>wrote:
if (!object) {
// sniffs the string to create a new objectobject = [QSObject objectWithString:directID];object = [QSAction actionWithIdentifier:directID];I keep a copy of the B54 code (or at least its the oldest commit we have)
for reference. Theres no mention ofQSActionin that method. My guess is
something got copied and pasted, but not changed to suit the new context. I
say yank it.Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/494/files#r158319
|
Sorry, thought I'd already pushed the fix here, but it was on another branch. Should be fine now :) |
|
Some observations:
|
|
Wait, maybe Show Playing Track does work. Tried it again without anything else merged in. Still investigating. |
|
Well, now I don’t know what to think, but long story short, this looks good. I’ll run with it for a bit before merging. |
|
This definitely fixed the show playing track problem for me. You can see if Probably worth opening an issue for eject - network volumes. On 10 October 2011 16:32, Rob McBroom <
|
Yes, I see that. I had it merged with a bunch of other stuff when it wasn’t working, although I am now running with the same stuff and it’s fine. It seems that I have to remove
Anyway, you can see why I gave only the short version. :)
Yeah. |
|
Well. I tried my triggers branch and it didn't fix the problem for me :/ I looked through the code and couldn't see anywhere where I may have fixed the problem. I think this is good to go :) |
Two things:
I've also updated to a 10.6 method for ejection (this method now ejects all volumes for the specified mounted drive). e.g. if you have a drive with 3 partitions and ask to eject one, it'll eject all 3 - not sure if this is unwanted or not.
Shouldn't have been working on these, but with no internet I can't really work on the plugin system :(