Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trigger #563

Closed
wants to merge 3 commits into from
Closed

Add trigger #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5197d41
Fix empty trigger creation after invoking "Add Trigger".
tiennou Nov 10, 2011
a76a709
Provoke a KVO notification when a trigger gets updated.
tiennou Nov 10, 2011
b14e940
Remove optional argument.
tiennou Nov 11, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Quicksilver/Code-App/QSTriggersPrefPane.m
View file
Open in desktop
Expand Up @@ -279,6 +279,8 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
//}

- (IBAction)triggerChanged:(id)sender {
[self willChangeValueForKey:@"triggerArray"];
[self didChangeValueForKey:@"triggerArray"];
[triggerTable reloadData];
}

Expand Down
7 changes: 3 additions & 4 deletions Quicksilver/Code-QuickStepCore/QSCommand.m
View file
Open in desktop
Expand Up @@ -118,7 +118,7 @@ - (QSObject *)saveCommand:(QSObject *)dObject toPath:(QSObject *)iObject {
return [QSObject fileObjectWithPath:destination];
}

- (QSObject*)addTrigger:(QSObject *)dObject withInfo:(QSObject*)iObject {
- (QSObject*)addTrigger:(QSObject *)dObject {
#warning TODO: iObject contains a string which allows passing missing parameters (trigger type, mainly)
/* More TODO: Ask the trigger's trigger manager to parse the iObject stringValue,
* so that trigger manager get a chance to customize their properties */
Expand Down Expand Up @@ -179,9 +179,8 @@ + (QSCommand *)commandWithInfo:(id)info {
command = [QSCommand commandWithDictionary:info];
} else if ([info isKindOfClass:[NSString class]]) {
command = [QSCommand commandWithIdentifier:info];
} else if (![info isKindOfClass:[QSCommand class]]) {
[self release];
return nil;
} else if ([info isKindOfClass:[QSCommand class]]) {
command = info;
}
return command;
}
Expand Down
2 changes: 1 addition & 1 deletion Quicksilver/PlugIns-Main/QSCorePlugIn/QSCorePlugIn-Info.plist
View file
Open in desktop
Expand Up @@ -634,7 +634,7 @@
<key>actionClass</key>
<string>QSCommandObjectHandler</string>
<key>actionSelector</key>
<string>addTrigger:withInfo:</string>
<string>addTrigger:</string>
<key>directTypes</key>
<array>
<string>qs.command</string>
Expand Down