New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made all alerts in QSController.m localisable. #568
Conversation
Localizable.strings just needs editing for each language
So if you use something other than English, is that a guaranteed crash? |
No. QS's default is to always drop back to the English if other languages On 14 November 2011 04:29, Rob McBroom <
|
This might be my fault. Last time I fiddled with Localization, I changed a lot of stuff.
should be changed to
That way, if all localization attempts fail, the original, non-localized string (@"Some String" in this case) will be used. I can't make the changes myself right now. So, @pjrobertson, will you just include them in this pull request? |
Yeah I definitely thought it was a but. I don't think it's just a bug with other languages (I get crashes when just On 14 November 2011 12:43, Henning Jungkurth <
|
With the changes I proposed, it would return the original string you put in, instead of nil. If you'd rather return @"", you should change NSBundle_BLTRExtensions.m#L77 instead. From:
to something like:
This way, it would return the default value if you provided one (using |
Conflicts: Quicksilver/Code-App/QSController.m
… localisation is found
@@ -695,6 +696,72 @@ - (void)checkForFirstRun { | |||
} | |||
|
|||
- (void)checkForCrash { | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think this is valid Objective-C. ;-)
Made all alerts in QSController.m localisable.
Localizable.strings just needs editing for each language
Please note: If I have wrapped a string in NSLocalizedString(@"Some String",nil) BUT @"Some String" isn't in Localised.strings then Quicksilver will most likely crash.
I have checked twice that I have done this all properly, but a third check from another would be appreciated.