Small fixes to the latest download proxy

[pjrobertson]

• Turns out stringByStandardizingPath doesn't resolve symlinks if the path contains a '~'. We must resolve that first then symlinks
• Added a check to make sure the downloads folder exists (i.e. no error in contentsOfDirectoryAtURL:...)
• Made sure to only create and return an object if something exists in mrdpath, otherwise return nil

This should fix #596.
I say 'should' because I haven't actually tested it agains a symlinked folder. I don't want to have to mess with my downloads folder. 100sGB + flaky old MacBook on Lion = me worrying all the time

[jewmihendrix]

This might be a stupid question, but how do I input that code in order to ameliorate the issue? Thanks a lot for the solution too, greatly appreciated.

[skurfer]

If you want to try this out before it’s incorporated into a release, I’ve written up some instructions (but it assumes you already know a bit about Xcode and Git).

http://projects.skurfer.com/posts/2011/building_the_latest/

[pjrobertson]

Easiest solution is to merge this ;-)

P.S. - Rob, as per my question about the plugins dev doc going on
QSApp.com, could this post also go somewhere useful - the wiki?

On 3 January 2012 17:39, Rob McBroom <
reply@reply.github.com

wrote:

If you want to try this out before its incorporated into a release, Ive
written up some instructions (but it assumes you already know a bit about
Xcode and Git).

http://projects.skurfer.com/posts/2011/building_the_latest/

---

Reply to this email directly or view it on GitHub:
#602 (comment)

[skurfer]

Easiest solution is to merge this ;-)

Yeah, I swear I went through looking for “easy ones” that could be merged but maybe not. This certainly qualifies.

[skurfer]

could this post also go somewhere useful - the wiki?

No objections, but it’s pretty low on the list. :-)

[skurfer]

A bit late now, but I just discovered the fullyResolvedPathForPath: in NSFileManager_BLTRExtensions.m. Maybe that’s what we should use here?

[pjrobertson]

Aaah you're probably right. I hadn't seen that. It does look a bit overkill here though.

I guess if more users are still reporting crashes and problems, then we should change it.