Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using Move to.../Copy to... set the 3rd pane object to the parent directory of the file to be moved/copied #665

Merged
merged 6 commits into from Jan 31, 2012
Merged

When using Move to.../Copy to... set the 3rd pane object to the parent directory of the file to be moved/copied #665

merged 6 commits into from Jan 31, 2012

Commits on Jan 26, 2012

  1. When using Move to.../Copy to... set the 3rd pane object to the paren… 

    …t directory of the file to be moved/copied
    @pjrobertson
    pjrobertson committed Jan 26, 2012
    Copy the full SHA
    9611e8d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2012

  1. Tidy up the Copy/Move To... iObjects 

    This commit:

* Obtains the list of objects more cleanly (using mutableCopy)
* Ensures a new file object for the folder isn't created if it already exists
* Performs a more robust check for bundles (using NSWorkspace's `isFilePackageAtPath`)
* Creates one instance of NSFileManager as opposed to thousands (for each run of the for loop)

Thanks to @skurfer for tips
    @pjrobertson
    pjrobertson committed Jan 27, 2012
    Copy the full SHA
    33eeca2 View commit details
    Browse the repository at this point in the history

  2. Don't check if the object's already been created. 

    This is already done in `fileObjectWithPath
    @pjrobertson
    pjrobertson committed Jan 27, 2012
    Copy the full SHA
    d2bc207 View commit details
    Browse the repository at this point in the history

  3. Only send a "SearchObjectChanged" notif is the object really changed

    @pjrobertson
    pjrobertson committed Jan 27, 2012
    Copy the full SHA
    de9dc40 View commit details
    Browse the repository at this point in the history

  4. Correctly define the getter/setter methods for searchArray 

    searchArray is an NSMutableArray, yet these methods refer to NSArrays.
Code has been checked for all occurrences of `setSearchArray` and they all set an NSMutableArray
    @pjrobertson
    pjrobertson committed Jan 27, 2012
    Copy the full SHA
    4099157 View commit details
    Browse the repository at this point in the history

  5. Only allow disabling of catalog in debug builds 

    Hopefully fixes quicksilver#630
    @pjrobertson
    pjrobertson committed Jan 27, 2012
    Copy the full SHA
    4d801ec View commit details
    Browse the repository at this point in the history