Don't attempt to close the QS window even when it's not open

[pjrobertson]

Do we need pull requests for things this small?!

[skurfer]

So prior to this change, every time you changed applications, Quicksilver would go through that “hiding” process?

[pjrobertson]

Yep. Which meant, every time you changed applications, Quicksilver would
try and clean the object dictionary, try and close the Quicklook panel (if
it was open), check wether it should close with 'superfluous' visual
effects...

and then close nothing. Efficiency eh?

On 10 May 2012 18:28, Rob McBroom <
reply@reply.github.com

wrote:

So prior to this change, every time you changed applications, Quicksilver
would go through that “hiding” process?

---

Reply to this email directly or view it on GitHub:
#872 (comment)

[pjrobertson]

My thoughts are (possibly) the appChanged notification and hence
cleanObjectDictionary action was getting called before QS had properly
loaded so it was messing with the objectDictionary and causing it to crash.
Hopefully it fixes a crash. Worst case - it just makes QS way more efficient

On 10 May 2012 18:31, Patrick Robertson robertson.patrick@gmail.com wrote:

Yep. Which meant, every time you changed applications, Quicksilver would
try and clean the object dictionary, try and close the Quicklook panel (if
it was open), check wether it should close with 'superfluous' visual
effects...

and then close nothing. Efficiency eh?

On 10 May 2012 18:28, Rob McBroom <
reply@reply.github.com

wrote:

So prior to this change, every time you changed applications, Quicksilver
would go through that “hiding” process?

---

Reply to this email directly or view it on GitHub:
#872 (comment)

[skurfer]

Yeah, I was just reading your notes on cleanObjectDictionary so I can see why you want this in. Merging.