Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to close the QS window even when it's not open #872

Merged
merged 1 commit into from May 10, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 10, 2012

Do we need pull requests for things this small?!

@skurfer
Copy link
Member

@skurfer skurfer commented May 10, 2012

So prior to this change, every time you changed applications, Quicksilver would go through that “hiding” process?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented May 10, 2012

Yep. Which meant, every time you changed applications, Quicksilver would
try and clean the object dictionary, try and close the Quicklook panel (if
it was open), check wether it should close with 'superfluous' visual
effects...

and then close nothing. Efficiency eh?

On 10 May 2012 18:28, Rob McBroom <
reply@reply.github.com

wrote:

So prior to this change, every time you changed applications, Quicksilver
would go through that “hiding” process?


Reply to this email directly or view it on GitHub:
#872 (comment)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented May 10, 2012

My thoughts are (possibly) the appChanged notification and hence
cleanObjectDictionary action was getting called before QS had properly
loaded so it was messing with the objectDictionary and causing it to crash.
Hopefully it fixes a crash. Worst case - it just makes QS way more efficient

On 10 May 2012 18:31, Patrick Robertson robertson.patrick@gmail.com wrote:

Yep. Which meant, every time you changed applications, Quicksilver would
try and clean the object dictionary, try and close the Quicklook panel (if
it was open), check wether it should close with 'superfluous' visual
effects...

and then close nothing. Efficiency eh?

On 10 May 2012 18:28, Rob McBroom <
reply@reply.github.com

wrote:

So prior to this change, every time you changed applications, Quicksilver
would go through that “hiding” process?


Reply to this email directly or view it on GitHub:
#872 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented May 10, 2012

Yeah, I was just reading your notes on cleanObjectDictionary so I can see why you want this in. Merging.

skurfer added a commit that referenced this issue May 10, 2012
Don't attempt to close the QS window even when it's not open
@skurfer skurfer merged commit 1c8470f into quicksilver:master May 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants