Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes #20

Merged
merged 4 commits into from Oct 24, 2013
Merged

small fixes #20

merged 4 commits into from Oct 24, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 14, 2013

  • Nothing under "Recent Tracks" was really useful as a track object because the Persistent ID didn't match what was in the library.
  • When adding to a playlist, the default playlist in the third pane was random. Now it should be the one you use most.

@pjrobertson
Copy link
Member

iTunes is always a funny beast... the code looks strange, but I don't think it's your fault ;-)

So the notif send a dict with @"persistentID" but the XML file uses @"Persistent ID" so all you're doing is switching the two?
Two questions:

  • why convert to an NSString and not store it using an NSNumber in the dict?
  • pidNumber is a little confusing as a variable name, when I saw it I thought of process id. Not a biggy though.

@skurfer
Copy link
Member Author

skurfer commented Oct 18, 2013

So the notif send a dict with @"persistentID" but the XML file uses @"Persistent ID" so all you're doing is switching the two?

Don’t be silly! persistentID is the key for Scripting Bridge. The NSNotification uses PersistentID, and the XML uses Persistent ID. Make sense? 😉

There’s a new API for the iTunes library in 10.9 that I’ll be looking into, but no real hurry.

why convert to an NSString and not store it using an NSNumber in the dict?

The XML version stores a hex number as a string. That’s what we need to emulate.

@pjrobertson
Copy link
Member

Alright cool. If you're not fussed about the pidNumber name, merge. But I still would like it to be a little clearer ;-)
Then merge :P

skurfer added a commit that referenced this pull request Oct 24, 2013
@skurfer skurfer merged commit 6e2c9f9 into master Oct 24, 2013
@skurfer skurfer deleted the recents branch February 14, 2014 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants