-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdditionalProperties ignored for Typescript definition generation #1615
Comments
Any update on this? I'm having the same issue 10 months later. Also glad to help with a PR! |
ReneWerner87
added a commit
to ReneWerner87/quicktype
that referenced
this issue
Dec 8, 2022
ReneWerner87
added a commit
to ReneWerner87/quicktype
that referenced
this issue
Dec 8, 2022
ReneWerner87
added a commit
to ReneWerner87/quicktype
that referenced
this issue
Dec 9, 2022
ReneWerner87
added a commit
to ReneWerner87/quicktype
that referenced
this issue
Dec 9, 2022
dvdsgl
pushed a commit
that referenced
this issue
Dec 30, 2022
* AdditionalProperties ignored for Typescript definition generation #1615 #1615 * AdditionalProperties ignored for Typescript definition generation #1615 #1615 * AdditionalProperties ignored for Typescript definition generation #1615 #1615 * AdditionalProperties ignored for Typescript definition generation #1615 #1615 * revert package.json changes
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the amazing work done in this library !
I'm struggling a bit with
additionalProperties
JSON-schema property.As stated from the documentation:
So, not defining
additionalProperties
is equivalent to"additionalProperties": true
However, given the following JSON-schema
the generated Typescript definition is
while I was expecting
I tried setting
"additionalProperties": true
and even"additionalProperties": { type: "string" }
, without any success. It looks likeadditionalProperties
does not have any impact on generated Typescript definition.You can access my latest test at https://app.quicktype.io?share=Y4Y07xZGS9zncuWpEtSt
Any advice on how to proceed with this issue ? Happy to help with a PR if pointed in the right direction :)
The text was updated successfully, but these errors were encountered: