Empty scratch directory on startup #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload--empty-scratch-dir-on-startup
branch
from
9e94d7c
to
1d7d903
Compare
guilload
force-pushed
the
guilload--empty-scratch-dir-on-startup
branch
from
1d7d903
to
1212c43
Compare
fulmicoton
requested changes
Oct 1, 2021
There was a problem hiding this comment.
That won't work because the quickwit-cache directory used fro the upload cache is a subdir of that dir.
We don't want to remove it.
One fix could be to add create a dir called scratch on top of the indexing directory.
indexing-directory/
scratch/
quickwit-cache/
We might want to rename quickwit-cache split-cache too.
|
Ok, I was not aware of that. So yeah, let's create the upload cache in a separate folder. I'll update this PR. |
|
@guilload it was not merge when you fixed the bug :) |
|
Superceeded by #644. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Empty scratch directory on startup. Fixes #599.
How was this PR tested?
Added unit tests.