Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when opening old indexes #1754

Open
gyk opened this issue Jan 3, 2023 · 4 comments
Open

Panic when opening old indexes #1754

gyk opened this issue Jan 3, 2023 · 4 comments

Comments

@gyk
Copy link
Contributor

gyk commented Jan 3, 2023

Describe the bug

Tantivy panics when reading an index of old version with no DOC_STORE_VERSION field in the footer:

thread 'MainLoop' panicked at 'actual doc store version: 2222222222, expected: 1', tantivy-0.19.0\src\store\footer.rs:30:13
@PSeitz
Copy link
Contributor

PSeitz commented Jan 5, 2023 •
edited

@gyk There was a breaking change in the format for 0.19. We don't support reading older versions

@gyk
Copy link
Contributor Author

gyk commented Jan 6, 2023

It would be better to return an Err rather than panicking.

@cjrh
Copy link
Contributor

cjrh commented Feb 16, 2023 •
edited

@PSeitz is there a guarantee on compatibility for patch version changes? e.g., will all versions in 0.19.X have a guarantee to work on the same index structure?

@PSeitz
Copy link
Contributor

PSeitz commented Feb 16, 2023

Yes, patch versions will work on the same index. They only contain bugfixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjrh @PSeitz @gyk