-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BitPacker4x::num_bits_sorted SIGSEGV on empty arrays #23
Comments
Good point! Let's fix this. |
@Kerollmops also, if you intend to use bitpacking for meili, make sure to bitpack on blocks with a limit size. (typically 128 ints.) |
@fulmicoton, what do you mean by a block with a limit size? |
What I meant is : you do not want to compute the bit size for your entire postlist and stick to it. The reason is that the compression rate will then be determined by your largest delta. If your posting list has millions of elements you will probably end up having on outlier ruin the entire compression. |
Ok so the It makes perfect sense to me, thank you! |
Yes. I'll update doc and add an assert. Your first block required numbits=10 and the second one numbits=15. |
I have computed and added the (Whooops, the SIGSEGV is not fixed, I reopened) |
The block in arguments need to be of len BLOCK_LEN Closes #23
When called with an empty array the
num_bits_sorted
triggers a segfault, this is not specified anywhere that the array must not be empty (or do I missed it?).If you want to easily reproduce the bug just create an empty
vec![]
and give it toBitPacker4x::num_bits_sorted
.The text was updated successfully, but these errors were encountered: