Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger catch-up callback when node is lagging behind #128

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Trigger catch-up callback when node is lagging behind #128

merged 1 commit into from
Feb 26, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented Feb 23, 2024 •
edited
Loading

Todo

  • add unit test

fulmicoton
fulmicoton reviewed Feb 26, 2024
View reviewed changes
chitchat/src/lib.rs Outdated Show resolved Hide resolved
fulmicoton added a commit that referenced this pull request Feb 26, 2024
@fulmicoton
Bugfix: validation of delta before applying them.
786bf89 
Due to the nature UDP, the existence of resets and the fact that we are
gossipping to several nodes at the same time, it is possible for our
obsolete deltas to arrive.

This PR adds some validation to detect if the delta is valid, and
whether it will bring us to a better state or not.

It also removes the nodes to reset information, which was actually
taking a large amount of the MTU on large clusters.
(For 20 nodes, around 1KB)

Reset is now just expressed by sending the delta with `from_version = 0`.

Closes #128
@guilload guilload changed the title Trigger catch-up callback when self nodes is included in nodes to reset Trigger catch-up callback when node is lagging behind Feb 26, 2024
@guilload guilload merged commit ad4af71 into main Feb 26, 2024
2 checks passed
@guilload guilload deleted the guilload/catch-up-callback branch February 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guilload @fulmicoton