Fix labels used by Prometheus Operator to load #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlamirault
commented
May 2, 2024
nlamirault
commented
- used additional labels for ServiceMonitor and PrometheusRule used by the Prometheus Operator
- typo on PrometheusRule field
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
This was referenced May 2, 2024
rdettai
reviewed
May 6, 2024
Comment on lines
+8
to
+10
| {{- with .Values.serviceMonitor.additionalLabels }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
do we really need an extra set of additionalLabels? Can't the Prometheus operator be configured to use the quickwit.labels which are already configurable?
There was a problem hiding this comment.
It's a common pattern in the Prometheus Operator community to have these labels for ServiceMonitor, PodMonitor, PrometheusRule, ...
Ex:
- https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-elasticsearch-exporter/templates/prometheusrule.yaml
- https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-elasticsearch-exporter/templates/podmonitor.yaml
- https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-elasticsearch-exporter/templates/servicemonitor.yaml
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.