Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #18: add queryParser module #32

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 52 additions & 17 deletions pkg/quickwit/response_parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,58 @@ func parseResponse(responses []*es.SearchResponse, targets []*Query, configuredF
return &result, nil
}

func isLuceneOperator(value string) bool {
operators := []string{"or", "and"}
for _, op := range operators {
if strings.ToLower(value) == op {
return true
}
}

return false
}

func parseLuceneQuery(query string) []string {
var keywords []string

termRegex := regexp.MustCompile(`("[^"]+"|\S+)`)
keyValueRegex := regexp.MustCompile(`[^:]+:([^:]*)`)
termMatches := termRegex.FindAllString(query, -1)

for _, termMatch := range termMatches {
if termMatch[0] == '"' && termMatch[len(termMatches)-1] == '"' {
termMatch = termMatch[1 : len(termMatch)-1]
}

keyValueMatches := keyValueRegex.FindStringSubmatch(termMatch)
if len(keyValueMatches) <= 1 {
value := strings.ReplaceAll(termMatch, "*", "")
if isLuceneOperator(value) {
continue
}
keywords = append(keywords, value)
continue
}

for _, keyValueMatch := range keyValueMatches[1:] {
value := strings.ReplaceAll(keyValueMatch, "*", "")
if isLuceneOperator(value) {
continue
}
keywords = append(keywords, value)
}
}

return keywords
}

func processLogsResponse(res *es.SearchResponse, target *Query, configuredFields es.ConfiguredFields, queryRes *backend.DataResponse) error {
propNames := make(map[string]bool)
docs := make([]map[string]interface{}, len(res.Hits.Hits))
searchWords := make(map[string]bool)

highlights := parseLuceneQuery(target.RawQuery)

for hitIdx, hit := range res.Hits.Hits {
var flattened map[string]interface{}
if hit["_source"] != nil {
Expand Down Expand Up @@ -132,23 +179,6 @@ func processLogsResponse(res *es.SearchResponse, target *Query, configuredFields
propNames[key] = true
}

// FIXME: Quickwit does not support highlight. Should we replace this by a custom highlighter?
// Process highlight to searchWords
if highlights, ok := doc["highlight"].(map[string]interface{}); ok {
for _, highlight := range highlights {
if highlightList, ok := highlight.([]interface{}); ok {
for _, highlightValue := range highlightList {
str := fmt.Sprintf("%v", highlightValue)
matches := searchWordsRegex.FindAllStringSubmatch(str, -1)

for _, v := range matches {
searchWords[v[1]] = true
}
}
}
}
}

docs[hitIdx] = doc
}

Expand All @@ -158,6 +188,11 @@ func processLogsResponse(res *es.SearchResponse, target *Query, configuredFields
frames := data.Frames{}
frame := data.NewFrame("", fields...)
setPreferredVisType(frame, data.VisTypeLogs)

for _, keyword := range highlights {
searchWords[keyword] = true
}

setLogsCustomMeta(frame, searchWords, stringToIntWithDefaultValue(target.Metrics[0].Settings.Get("limit").MustString(), defaultSize))
frames = append(frames, frame)

Expand Down
45 changes: 45 additions & 0 deletions pkg/quickwit/response_parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3178,6 +3178,51 @@ func TestLabelOrderInFieldName(t *testing.T) {
requireTimeSeriesName(t, "val1 error", frames[5])
}

func TestParseLuceneQuery(t *testing.T) {
t.Run("Empty term query", func(t *testing.T) {
query := ""
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 0)
})

t.Run("Simple term query", func(t *testing.T) {
query := "foo"
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 1)
require.Equal(t, "foo", highlights[0])
})

t.Run("Multi term query", func(t *testing.T) {
query := "foo bar"
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 2)
require.Equal(t, "foo", highlights[0])
require.Equal(t, "bar", highlights[1])
})

t.Run("Wildcard query", func(t *testing.T) {
query := "foo*"
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 1)
require.Equal(t, "foo", highlights[0])
})

t.Run("KeyValue query", func(t *testing.T) {
query := "foo:bar*"
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 1)
require.Equal(t, "bar", highlights[0])
})

t.Run("MultiKeyValue query", func(t *testing.T) {
query := "foo:bar* AND foo2:bar2"
highlights := parseLuceneQuery(query)
require.Len(t, highlights, 2)
require.Equal(t, "bar", highlights[0])
require.Equal(t, "bar2", highlights[1])
})
}

func TestFlatten(t *testing.T) {
t.Run("Flattens simple object", func(t *testing.T) {
obj := map[string]interface{}{
Expand Down