Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quickwit to tantivy main and remove chrono #1232

Closed
fulmicoton opened this issue Mar 28, 2022 · 0 comments · Fixed by #1237 or #1243
Closed

Update quickwit to tantivy main and remove chrono #1232

fulmicoton opened this issue Mar 28, 2022 · 0 comments · Fixed by #1237 or #1243
Assignees
@PSeitz
Labels
bug Something isn't working
Projects
Quickwit 0.3

Comments

@fulmicoton
Copy link
Contributor

Right now quickwit relies on chrono and pulls 3 different version of std::time, some of which have known securities issues.

cargo deny
cargo tree -i time

We need to remove the deps to chrono, and upgrade tantivy.
@fulmicoton fulmicoton added the bug Something isn't working label Mar 28, 2022
@fulmicoton fulmicoton added this to To do in Quickwit 0.3 Mar 29, 2022
@PSeitz PSeitz linked a pull request Mar 29, 2022 that will close this issue
update tantivy #1237
Merged
@PSeitz PSeitz reopened this Mar 29, 2022
@PSeitz PSeitz mentioned this issue Mar 29, 2022
Closed
@PSeitz PSeitz linked a pull request Mar 30, 2022 that will close this issue
remove chrono #1243
Merged
PSeitz added a commit to PSeitz/quickwit that referenced this issue Mar 30, 2022
@PSeitz
remove chrono
ec500b9 
closes quickwit-oss#1232
PSeitz added a commit that referenced this issue Mar 31, 2022
@PSeitz
remove chrono (#1243)
90b8b58 
closes #1232
@fulmicoton fulmicoton moved this from To do to Done in Quickwit 0.3 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSeitz PSeitz

Labels
bug Something isn't working
Projects
No open projects
Quickwit 0.3
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update tantivy PSeitz/quickwit
remove chrono PSeitz/quickwit
2 participants
@fulmicoton @PSeitz