Commit Kafka offsets on suggest truncate #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/commit-kafka-offset
branch
from
0dd88c4
to
edeb2ef
Compare
|
(no reviewer?) |
I think I meant to assign you as a reviewer. |
fulmicoton
approved these changes
Sep 26, 2023
guilload
force-pushed
the
guilload/commit-kafka-offset
branch
from
edeb2ef
to
7b030eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users rely on committed offsets to monitor ingestion lag and trigger retention.
If you wonder why I'm doing this now, I'm just trying to dust off old branches accumulating on my machine :)
How was this PR tested?