Add stream splits gRPC. #4109
Merged
Add stream splits gRPC. #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
force-pushed
the
fmassot/add-stream-splits-rpc
branch
from
3731e99
to
eb3af54
Compare
fmassot
force-pushed
the
fmassot/add-stream-splits-rpc
branch
3 times, most recently
from
22ded45
to
d51708f
Compare
guilload
reviewed
Nov 27, 2023
fmassot
force-pushed
the
fmassot/add-stream-splits-rpc
branch
4 times, most recently
from
af09056
to
8e193aa
Compare
guilload
approved these changes
Dec 6, 2023
quickwit/quickwit-metastore/src/metastore/file_backed_metastore/mod.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/file_backed_metastore/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrien Guillo <adrien@quickwit.io>
fmassot
force-pushed
the
fmassot/add-stream-splits-rpc
branch
from
d653037
to
fa91de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
stream_splitsgRPC method and remove thelist_splitsgRPC method.I found it a bit more convenient to add a
list_splitsmethod in theMetastoreServiceExttrait rather than enriching the service stream response by adding some helpers to pump the stream and deserialize the splits.TODO: