Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/4184 assign shard logic #4223

Merged
merged 4 commits into from Dec 5, 2023
Merged

Issue/4184 assign shard logic #4223

merged 4 commits into from Dec 5, 2023

Commits on Dec 5, 2023

  1. Bugfix: IndexPipeline remembers list of shards and applies it after r… 

    …espawn

Bugfix Assign shard logic.

If no shard is removed, we just kill the pipeline.
If shards are added we reinitiate the shards.
The pipeline supervisor keeps track of the shard, and reassigns them if
the pipeline is respawned.

Closes #4184
Closes #4174
    @fulmicoton
    fulmicoton committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    64fca08 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Adrien Guillo <adrien@quickwit.io>
    @fulmicoton @guilload
    fulmicoton and guilload committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    04c2190 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Adrien Guillo <adrien@quickwit.io>
    @fulmicoton @guilload
    fulmicoton and guilload committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a87a6ef View commit details
    Browse the repository at this point in the history

  4. Clearer contract for reset_if_needed and fixing unit test

    @fulmicoton
    fulmicoton committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    7075d3f View commit details
    Browse the repository at this point in the history