Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populates the control plane model will closed and open shards #4235

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

fulmicoton
Copy link
Contributor

as opposed to only open ones.

Closes shards are not necessarily entirely indexed yet. With this change, after a reload, the closed shards will be scheduling for indexing as usual, and will get cleaned up once they reach eof.

Closes #4176

Copy link
Member

@guilload guilload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the load_from_metastore unit test?

@fulmicoton fulmicoton force-pushed the issue/4176-consider-closed-shards branch from 5b0a931 to a00d274 Compare December 5, 2023 00:53
@fulmicoton fulmicoton enabled auto-merge (squash) December 5, 2023 00:54
@fulmicoton fulmicoton force-pushed the issue/4176-consider-closed-shards branch from a00d274 to ec3a0c3 Compare December 5, 2023 01:39
as opposed to only open ones.

Closes shards are not necessarily entirely indexed yet.
With this change, after a reload, the closed shards will be
scheduling for indexing as usual, and will get cleaned up once
they reach eof.

Closes #4176
@fulmicoton fulmicoton force-pushed the issue/4176-consider-closed-shards branch from ec3a0c3 to 4c92bf7 Compare December 5, 2023 01:55
@fulmicoton fulmicoton merged commit 1e9ad73 into main Dec 5, 2023
4 checks passed
@fulmicoton fulmicoton deleted the issue/4176-consider-closed-shards branch December 5, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control plane should delete closed shard on startup.
2 participants