Populates the control plane model will closed and open shards #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
Dec 4, 2023
fulmicoton
force-pushed
the
issue/4176-consider-closed-shards
branch
from
5b0a931
to
a00d274
Compare
fulmicoton
force-pushed
the
issue/4176-consider-closed-shards
branch
from
a00d274
to
ec3a0c3
Compare
as opposed to only open ones. Closes shards are not necessarily entirely indexed yet. With this change, after a reload, the closed shards will be scheduling for indexing as usual, and will get cleaned up once they reach eof. Closes #4176
fulmicoton
force-pushed
the
issue/4176-consider-closed-shards
branch
from
ec3a0c3
to
4c92bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as opposed to only open ones.
Closes shards are not necessarily entirely indexed yet. With this change, after a reload, the closed shards will be scheduling for indexing as usual, and will get cleaned up once they reach eof.
Closes #4176