Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate documents #5046

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Validate documents #5046

merged 1 commit into from
Jun 19, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented May 29, 2024

Description

Parse and validate documents before persisting them into WAL. Returns parse failures to clients.

How was this PR tested?

Added unit tests.

@guilload guilload changed the base branch from main to guilload/ingest-doc-validation May 29, 2024 19:07
@guilload guilload force-pushed the guilload/router-validates-docs branch from 14ea667 to f29f00f Compare May 29, 2024 21:57
@guilload guilload force-pushed the guilload/ingest-doc-validation branch 2 times, most recently from 6f73b42 to a0e3f3b Compare May 30, 2024 16:34
@guilload guilload force-pushed the guilload/router-validates-docs branch 3 times, most recently from 617f500 to 36c339f Compare May 30, 2024 18:03
@guilload guilload force-pushed the guilload/ingest-doc-validation branch from a0e3f3b to 1e73a04 Compare May 30, 2024 20:28
@guilload guilload force-pushed the guilload/router-validates-docs branch 2 times, most recently from 7595d3e to 95e600e Compare May 30, 2024 22:38
@guilload guilload force-pushed the guilload/router-validates-docs branch 2 times, most recently from 6d39838 to 1007ce1 Compare May 31, 2024 15:24
@guilload guilload force-pushed the guilload/router-validates-docs branch from 1007ce1 to a55c439 Compare May 31, 2024 16:50
@guilload guilload force-pushed the guilload/router-validates-docs branch from a55c439 to 5a9765a Compare May 31, 2024 20:01
@guilload guilload force-pushed the guilload/ingest-doc-validation branch 3 times, most recently from e38b9db to 3d79671 Compare June 11, 2024 20:29
@guilload guilload force-pushed the guilload/router-validates-docs branch from 5a9765a to 345b937 Compare June 13, 2024 15:35
Copy link

github-actions bot commented Jun 13, 2024

On SSD:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 2213, ref commit: cbe87f6
Link

On GCS:

Average search latency is 0.974x that of the reference (lower is better).
Ref run id: 2214, ref commit: cbe87f6
Link

@guilload guilload force-pushed the guilload/router-validates-docs branch 2 times, most recently from c80150a to 380222a Compare June 18, 2024 22:31
@guilload guilload force-pushed the guilload/ingest-doc-validation branch from 3d79671 to 892c5d5 Compare June 19, 2024 16:12
Base automatically changed from guilload/ingest-doc-validation to main June 19, 2024 16:33
@guilload guilload force-pushed the guilload/router-validates-docs branch 2 times, most recently from a22ef7c to be17ec7 Compare June 19, 2024 17:14
@guilload guilload marked this pull request as ready for review June 19, 2024 17:14
@guilload guilload force-pushed the guilload/router-validates-docs branch 2 times, most recently from 94de67e to 52a6d98 Compare June 19, 2024 18:42
@guilload guilload force-pushed the guilload/router-validates-docs branch from 52a6d98 to 5dd4c68 Compare June 19, 2024 18:44
@guilload guilload merged commit ca97595 into main Jun 19, 2024
5 checks passed
@guilload guilload deleted the guilload/router-validates-docs branch June 19, 2024 19:09
fulmicoton pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants