Add es resolve api #5113
Merged
Add es resolve api #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This [method][1] is used by Opensearch Dashboards when user typing index name in pattern creation UI. OpenSearch Dashboard makes first request with `*:*` pattern which should be converted to `*` as QuickWit do not support `:` in the index name. This part is not implemented within this PR. [1]: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/indices-resolve-index-api.html
Seems left over from prev development as are we [passing](quickwit/quickwit-serve/src/elasticsearch_api/mod.rs:81) `metastore` service.
kuzaxak
force-pushed
the
add_es_resolve_api
branch
from
99556f9
to
536a955
Compare
Took params from `cat_indices.rs` and followed common structure of the page.
fulmicoton
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method is used by Opensearch Dashboards when user typing index
name in pattern creation UI.
Case that is not handled within this change is
*:*pattern which should be converted to*as QuickWit do not support:in the index name.How was this PR tested?
Tested on own cluster. Couldn't figure out how to add integration tests to cover ES functionality.