Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the default number of threads for the main tokio runtime. #5124

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Changing the default number of threads for the main tokio runtime. #5124

merged 1 commit into from
Jun 14, 2024

Conversation

fulmicoton
Copy link
Contributor

The new default value is num_cores / 3.
This value can be overridden using the QW_RUNTIME_NUM_THREADS environment variable.

Closes #5123

@fulmicoton
Changing the default number of threads for the main tokio runtime.
139ca51 
The new default value is num_cores / 3.
This value can be overridden using the QW_RUNTIME_NUM_THREADS
environment variable.

Closes #5123
@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 2094, ref commit: e47d08a
Link

On GCS:

Average search latency is 1.04x that of the reference (lower is better).
Ref run id: 2095, ref commit: e47d08a
Link

@fulmicoton fulmicoton merged commit 8a69c73 into main Jun 14, 2024
5 checks passed
@fulmicoton fulmicoton deleted the 5123/main-runtime-num-threads branch June 14, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main Tokio runtime is using too many threads on indexers
2 participants
@fulmicoton @trinity-1686a