Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse dense index #1716

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Sparse dense index #1716

merged 7 commits into from
Dec 13, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Dec 12, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #1716 (6c07d14) into main (96c93a6) will increase coverage by 0.03%.
The diff coverage is 99.38%.

@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
+ Coverage   94.07%   94.10%   +0.03%     
==========================================
  Files         259      261       +2     
  Lines       49637    50009     +372     
==========================================
+ Hits        46695    47063     +368     
- Misses       2942     2946       +4     
Impacted Files Coverage Δ
fastfield_codecs/src/lib.rs 98.89% <ø> (ø)
fastfield_codecs/src/null_index/dense.rs 99.37% <99.37%> (ø)
fastfield_codecs/src/null_index/mod.rs 100.00% <100.00%> (ø)
src/store/index/mod.rs 97.83% <0.00%> (-0.55%) ⬇️
src/fastfield/multivalued/mod.rs 98.06% <0.00%> (-0.39%) ⬇️
src/aggregation/bucket/histogram/histogram.rs 99.56% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the use null_index::* and please merge after the release.

Co-authored-by: Paul Masurel <paul@quickwit.io>
@PSeitz PSeitz merged commit a2cf6a7 into main Dec 13, 2022
@PSeitz PSeitz deleted the sparse_dense_index branch December 13, 2022 06:50
This was referenced Jan 13, 2023
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
* add dense codec

* benchmark fix and important optimisation

* move code to DenseIndexBlock

improve benchmark

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

* extend benchmarks

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants