Isolating sstable and stacker in independant crates. #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
stacker-sstable-refactor
branch
5 times, most recently
from
5a6dcb4
to
c7f6bdc
Compare
fulmicoton
force-pushed
the
stacker-sstable-refactor
branch
2 times, most recently
from
dddebc2
to
6cae790
Compare
Both crate will be used in the new (optional + dynamic) fastfield work.
fulmicoton
force-pushed
the
stacker-sstable-refactor
branch
2 times, most recently
from
1e45eac
to
59a11c5
Compare
fulmicoton
force-pushed
the
stacker-sstable-refactor
branch
from
59a11c5
to
44cdf14
Compare
PSeitz
reviewed
Dec 12, 2022
| /// | ||
| /// The quirky API has the benefit of avoiding | ||
| /// the computation of the hash of the key twice, | ||
| /// or copying the key as long as there is no insert. | ||
| pub struct TermHashMap { | ||
| pub struct ArenaHashMap { |
There was a problem hiding this comment.
I think the new name is too generic, the implementation is very specific, mapping &[u8] keys to ids
There was a problem hiding this comment.
Yeah... So Term will soon be incorrect, as I use the stacker with field names as keys in dynamic fast fields.
I could have something like ArenaBytesHashMap or something like this, but I think at this point ArenaHashMap is ok.
PSeitz
reviewed
Dec 12, 2022
PSeitz
reviewed
Dec 12, 2022
This was referenced Jan 13, 2023
Closed
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
Both crate will be used in the new (optional + dynamic) fastfield work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both crate will be used in the new (optional + dynamic) fastfield work.