Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update comments in the faceted search example #1737

Merged

Conversation

DawChihLiou
Copy link
Contributor

@DawChihLiou DawChihLiou commented Dec 22, 2022

This PR replaces the incorrect comment copied from the basic example with an explanation that describes the faceted search example.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #1737 (28058ae) into main (7385a8f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   94.13%   94.14%           
=======================================
  Files         266      267    +1     
  Lines       50814    50903   +89     
=======================================
+ Hits        47835    47921   +86     
- Misses       2979     2982    +3     
Impacted Files Coverage Δ
fastfield_codecs/src/null_index/sparse.rs 95.46% <0.00%> (-1.29%) ⬇️
stacker/src/expull.rs 98.33% <0.00%> (-0.56%) ⬇️
common/src/lib.rs 89.33% <0.00%> (ø)
fastfield_codecs/src/lib.rs 98.89% <0.00%> (ø)
common/src/group_by.rs 100.00% <0.00%> (ø)
fastfield_codecs/src/null_index/dense.rs 99.16% <0.00%> (+0.10%) ⬆️
src/indexer/segment_updater.rs 95.44% <0.00%> (+0.13%) ⬆️
src/schema/schema.rs 98.91% <0.00%> (+0.13%) ⬆️
fastfield_codecs/src/monotonic_mapping.rs 100.00% <0.00%> (+2.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton
Copy link
Collaborator

Can you fix the formatting? (Running make fmt should do the job) @DawChihLiou

@DawChihLiou
Copy link
Contributor Author

@fulmicoton Thanks for reviewing! I've formatted the change:)

@PSeitz PSeitz enabled auto-merge (squash) January 2, 2023 07:44
@PSeitz PSeitz merged commit b22f966 into quickwit-oss:main Jan 2, 2023
This was referenced Jan 13, 2023
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
* doc: update comments in the faceted search example

* chore: format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants