EnableScoring::Disabled - optional Searcher #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Jan 12, 2023
fulmicoton
approved these changes
Jan 12, 2023
|
@shikhar you can hit the squash and merge button I think you have the permissions! |
|
yup was just waiting on CI :) |
This was referenced Jan 13, 2023
Closed
fulmicoton
pushed a commit
that referenced
this pull request
Jan 16, 2023
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom
Querythat requires theSearcherinweight(..)(for looking up cached data used in matching that is kept warmed and keyed on searcher generation), even when scoring is disabled (e.g. usingDocSetCollector)So I am proposing to make a further API change on top of #1667 such that
EnableScoring::Disabledcan contain an optionalSearcher, and nudging towards providing it when available.Searcher::search(..)has been updated accordingly.