Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing alloc on all .next() in MultiValueColumn #1594

merged 2 commits into from Oct 5, 2022


Copy link

No description provided.

@fulmicoton fulmicoton requested a review from PSeitz October 5, 2022 08:13
Copy link

Codecov Report

Merging #1594 (7baa6e3) into main (0dc8c45) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1594   +/-   ##
  Coverage   93.74%   93.75%           
  Files         251      252    +1     
  Lines       46279    46324   +45     
+ Hits        43386    43432   +46     
+ Misses       2893     2892    -1     
Impacted Files Coverage Δ
src/indexer/ 100.00% <ø> (ø)
src/indexer/ 100.00% <100.00%> (ø)
src/indexer/ 95.38% <100.00%> (-0.21%) ⬇️
src/schema/ 100.00% <0.00%> (ø)
src/schema/ 100.00% <0.00%> (ø)
src/core/ 72.86% <0.00%> (ø)
src/postings/stacker/ 99.05% <0.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@PSeitz PSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome solution. I'll push a change to the branch to make it as ergonomic as flat_map

@PSeitz PSeitz merged commit 7905965 into main Oct 5, 2022
@PSeitz PSeitz deleted the flat_map_with_buffer branch October 5, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants