Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialise bytes as base64 strings instead of arrays. #1608

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

nigel-andrews
Copy link
Contributor

Description

Instead of serialising an array of bytes, encode that array to a base64 string and serialise it as a string instead.

Testing

Added tests to check the output of the serialisation.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #1608 (3b18908) into main (5945dbf) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   93.75%   93.80%   +0.04%     
==========================================
  Files         251      252       +1     
  Lines       46278    46419     +141     
==========================================
+ Hits        43388    43543     +155     
+ Misses       2890     2876      -14     
Impacted Files Coverage Δ
src/schema/value.rs 67.39% <100.00%> (+5.86%) ⬆️
src/indexer/sorted_doc_id_multivalue_column.rs 95.00% <0.00%> (-0.59%) ⬇️
src/fastfield/multivalued/writer.rs 98.34% <0.00%> (-0.03%) ⬇️
src/indexer/merger.rs 98.82% <0.00%> (-0.01%) ⬇️
src/reader/mod.rs 93.63% <0.00%> (ø)
src/schema/mod.rs 100.00% <0.00%> (ø)
src/indexer/mod.rs 100.00% <0.00%> (ø)
src/schema/text_options.rs 100.00% <0.00%> (ø)
src/fastfield/serializer/mod.rs 100.00% <0.00%> (ø)
src/core/inverted_index_reader.rs 72.86% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (PR is the same as #1607 which was already approved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants