Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing Bytes validation to term_agg #2077

Merged
merged 1 commit into from
Jun 12, 2023
Merged

add missing Bytes validation to term_agg #2077

merged 1 commit into from
Jun 12, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Jun 7, 2023

returns empty for now instead of failing like before

returns empty for now instead of failing like before
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #2077 (d888b7d) into main (4b7c485) will decrease coverage by 0.01%.
The diff coverage is 89.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
- Coverage   94.38%   94.38%   -0.01%     
==========================================
  Files         319      319              
  Lines       60041    60075      +34     
==========================================
+ Hits        56670    56700      +30     
- Misses       3371     3375       +4     
Impacted Files Coverage Δ
src/aggregation/bucket/term_agg.rs 98.28% <88.23%> (-0.32%) ⬇️
src/aggregation/agg_req_with_accessor.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@PSeitz PSeitz requested a review from fulmicoton June 12, 2023 06:56
@PSeitz PSeitz merged commit 657f0cd into main Jun 12, 2023
5 checks passed
@PSeitz PSeitz deleted the byte_term_agg branch June 12, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants