Fix bug that can cause get_docids_for_value_range to panic.
#2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
bugfix-rank-allowed-for-any-rows
branch
from
f488112
to
2579dc6
Compare
PSeitz
approved these changes
Jan 9, 2024
When `selected_docid_range.end == num_rows`, we would get a panic as we try to access a non-existing blockmeta. This PR accepts calls to rank with any value. For any value above num_rows we simply return non_null_rows. Fixes #2293
PSeitz
force-pushed
the
bugfix-rank-allowed-for-any-rows
branch
from
8ba5068
to
ba5030e
Compare
|
thanks for the quick fix! I can confirm that I'm not seeing the panic anymore after this change. |
PSeitz
added a commit
that referenced
this pull request
Apr 10, 2024
* Fix bug that can cause `get_docids_for_value_range` to panic. When `selected_docid_range.end == num_rows`, we would get a panic as we try to access a non-existing blockmeta. This PR accepts calls to rank with any value. For any value above num_rows we simply return non_null_rows. Fixes #2293 * add tests, merge variables --------- Co-authored-by: Pascal Seitz <pascal.seitz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
selected_docid_range.end == num_rows, we would get a panic as we try to access a non-existing blockmeta.This PR accepts calls to rank with any value.
For any value above num_rows we simply return non_null_rows.
Fixes #2293